Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Minor bug: ForwardingDispatcher accepts the CInterop LogLevel instead of UnityEngine.LogType #753

Closed
luna-duclos opened this issue Feb 13, 2019 · 2 comments
Closed

Minor bug: ForwardingDispatcher accepts the CInterop LogLevel instead of UnityEngine.LogType #753

luna-duclos opened this issue Feb 13, 2019 · 2 comments
Labels
A: core Area: Core GDK S: accepted Status: This issue has been accepted. T: enhancement Type: This is an improvement to an existing feature
Milestone
Release v0.2.4

Comments

@luna-duclos
Copy link

We are accepting issues and we want your feedback.

Description

A minor aesthethical issue mostly: The GDK's logging system normally does its best to abstract away CInterop stuff away from the end user. However, for the ForwardingDispatcher's constructor, it expects a CInterop.LogLevel as an argument

Expected behaviour

I'd expect it to accept a UnityEngine.LogType instead, like the rest of the log API

Current behaviour

It expects a CInterop.LogLevel instead, forcing me to reference that assembly.

Possible solution

Change it and translate between the two via the already existing LogTypeMapping dict

Steps to reproduce

N/A

Environment

N/A
@jamiebrynes7 jamiebrynes7 added T: enhancement Type: This is an improvement to an existing feature A: core Area: Core GDK S: being-considered Status: This issue is being considered. labels Feb 13, 2019
@jamiebrynes7
Copy link
Contributor

Tracking this internally as UTY-1953

@jamiebrynes7 jamiebrynes7 added S: accepted Status: This issue has been accepted. and removed S: being-considered Status: This issue is being considered. labels Apr 9, 2019
@jamiebrynes7 jamiebrynes7 added this to the Release v0.2.4 milestone May 24, 2019
jamiebrynes7 pushed a commit that referenced this issue Jun 11, 2019
fix logging + driveby of #753
75348ff
@jamiebrynes7 jamiebrynes7 mentioned this issue Jun 13, 2019
Merged
jamiebrynes7 pushed a commit that referenced this issue Jun 19, 2019
fix logging + driveby of #753
8e86a7b
@jamiebrynes7
Copy link
Contributor

Fixed in 0.2.4

jessicafalk pushed a commit that referenced this issue Nov 15, 2019
@m-samiec
Remove inline (#753)
664e682 
* Remove inline
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A: core Area: Core GDK S: accepted Status: This issue has been accepted. T: enhancement Type: This is an improvement to an existing feature
Projects
None yet
Milestone
Release v0.2.4
Development

No branches or pull requests
2 participants
@luna-duclos @jamiebrynes7