This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Use Unity logger types in ForwardingDispatcher #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
A: core
jessicafalk
approved these changes
Jun 13, 2019
|
Realized this is actually a breaking change as well - will edit the changelog |
paulbalaji
approved these changes
Jun 13, 2019
zeroZshadow
approved these changes
Jun 13, 2019
jamiebrynes7
force-pushed
the
bugfix/logger-compat
branch
from
5ef8612
to
d255a43
Compare
jessicafalk
pushed a commit
that referenced
this pull request
Nov 15, 2019
* * Fix the iOS building dependencies on Windows * * RequireSetup increment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pretty quick fix - use Unity's
LogTypeinstead of the C#IO'sLogLevel. Requested in #753(This was cherry-picked out of #844 where I driveby fixed in a few days ago).
Tests
Ran the game - logging still worked.
Documentation
Changelog + closes known issue.