Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Events no longer trigger component updates #1211

Merged
merged 4 commits into from
Nov 1, 2019
Merged

Events no longer trigger component updates #1211

merged 4 commits into from
Nov 1, 2019

Conversation

zeroZshadow
Copy link
Contributor

@zeroZshadow zeroZshadow commented Nov 1, 2019 •
edited
Loading

Description

Received component ops that don't contain any field updates, no longer trigger the OnUpdate callback.

Documentation

  • Changelog

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. A: maintenance Area: Project maintenance or hygiene A: mobile Area: Mobile integration A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module labels Nov 1, 2019
@zeroZshadow zeroZshadow changed the base branch from master to develop November 1, 2019 12:27
@improbable-prow-robot improbable-prow-robot added size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Nov 1, 2019
@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. labels Nov 1, 2019
paulbalaji
paulbalaji reviewed Nov 1, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@zeroZshadow
Update CHANGELOG.md
3da8273 
Co-Authored-By: Paul Balaji <paulbalaji@improbable.io>
@zeroZshadow zeroZshadow merged commit b386cda into develop Nov 1, 2019
@zeroZshadow zeroZshadow deleted the bugfix/events-trigger-component-updates branch November 1, 2019 15:36
@paulbalaji paulbalaji mentioned this pull request Dec 3, 2019
Merged
1 task
paulbalaji pushed a commit that referenced this pull request Dec 3, 2019
Cleared field bugfix of #1211 (#1229)
1bf0520
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulbalaji paulbalaji paulbalaji approved these changes

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@jessicafalk jessicafalk Awaiting requested review from jessicafalk

Assignees
No one assigned
Labels
A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: maintenance Area: Project maintenance or hygiene A: mobile Area: Mobile integration A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zeroZshadow @paulbalaji @jamiebrynes7 @improbable-prow-robot