Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Cleared field bugfix of #1211 #1229

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Cleared field bugfix of #1211 #1229

merged 5 commits into from
Dec 3, 2019

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Dec 3, 2019

Description

Tests

  • removed 1 map element every second on server, received updated on client
  • logged map count on server/client
  • observed client never made it to 0 before bugfix
  • correct behaviour observed after bugfix

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot
Copy link

Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2382

@improbable-prow-robot improbable-prow-robot added jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files. A: core Area: Core GDK labels Dec 3, 2019
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
@jamiebrynes7
Copy link
Contributor

For future reference - we could use the JSON representation of schema to test that we are serializing data correctly:

  • Serialize data/update into Schema_*
  • Convert into JSON
  • Validate the JSON against the expected structure

Paul Balaji added 2 commits December 3, 2019 12:09
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Co-Authored-By: Jamie Brynes <jamiebrynes@improbable.io>
@paulbalaji paulbalaji merged commit 1bf0520 into develop Dec 3, 2019
@paulbalaji paulbalaji deleted the bugfix/uty-2382 branch December 3, 2019 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK jira/UTY size/XS Denotes a PR that changes 0-14 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants