Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Remove workaround for a schema component update bug (WRK-1031). #962

Merged
merged 5 commits into from
Jun 3, 2019

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented May 31, 2019

Description

Removed the workaround for a schema component update bug (WRK-1031).

consider reading 1st and 3rd commit (2nd commit is generated code)

includes drive-by deployment launcher fix for uploading assemblies

Tests

  • local launch
  • cloud launch
  • premerge
  • release qa

Documentation

internal changelog entry

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added A: tooling Area: Tooling size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels May 31, 2019
@paulbalaji paulbalaji requested review from jamiebrynes7, jessicafalk and zeroZshadow and removed request for jamiebrynes7 May 31, 2019 15:58
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jessicafalk jessicafalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, made 2 small comments

@paulbalaji paulbalaji merged commit 7b3349e into develop Jun 3, 2019
@paulbalaji paulbalaji deleted the feature/remove-wrk-1031-workaround branch June 3, 2019 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: tooling Area: Tooling size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants