spatialos · paulbalaji · Jun 3, 2019 · May 31, 2019 · May 31, 2019 · May 31, 2019
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,10 @@
 
 - Fixed a bug where a worker's `World` could get disposed multiple times if you stopped the application inside the Editor while the worker is being created.
 
+### Internal
+
+- Removed the workaround for a schema component update bug (WRK-1031).
+
 ## `0.2.2` - 2019-05-15
 
 ### Breaking Changes

diff --git a/...Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapKeyComponentDiffDeserializer.cs b/...Assets/Generated/Source/improbable/gdk/tests/ExhaustiveMapKeyComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveMapValueComponentDiffDeserializer.cs b/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveMapValueComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveOptionalComponentDiffDeserializer.cs b/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveOptionalComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveRepeatedComponentDiffDeserializer.cs b/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveRepeatedComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveSingularComponentDiffDeserializer.cs b/...sets/Generated/Source/improbable/gdk/tests/ExhaustiveSingularComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/.../Assets/Generated/Source/improbable/gdk/tests/NestedComponentComponentDiffDeserializer.cs b/.../Assets/Generated/Source/improbable/gdk/tests/NestedComponentComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/.../Source/improbable/gdk/tests/alternateschemasyntax/ConnectionComponentDiffDeserializer.cs b/.../Source/improbable/gdk/tests/alternateschemasyntax/ConnectionComponentDiffDeserializer.cs
@@ -60,8 +60,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);
@@ -75,8 +73,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(1);
                         global::Improbable.Gdk.Tests.AlternateSchemaSyntax.RandomDataType.Serialization.Serialize(ev.Event.Payload, obj);

diff --git a/...Source/improbable/gdk/tests/blittabletypes/BlittableComponentComponentDiffDeserializer.cs b/...Source/improbable/gdk/tests/blittabletypes/BlittableComponentComponentDiffDeserializer.cs
@@ -73,8 +73,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);
@@ -88,8 +86,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(1);
                         global::Improbable.Gdk.Tests.BlittableTypes.FirstEventPayload.Serialization.Serialize(ev.Event.Payload, obj);
@@ -105,8 +101,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(2);
                         global::Improbable.Gdk.Tests.BlittableTypes.SecondEventPayload.Serialization.Serialize(ev.Event.Payload, obj);

diff --git a/...obable/gdk/tests/componentswithnofields/ComponentWithNoFieldsComponentDiffDeserializer.cs b/...obable/gdk/tests/componentswithnofields/ComponentWithNoFieldsComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/...ests/componentswithnofields/ComponentWithNoFieldsWithCommandsComponentDiffDeserializer.cs b/...ests/componentswithnofields/ComponentWithNoFieldsWithCommandsComponentDiffDeserializer.cs
@@ -46,8 +46,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);

diff --git a/.../tests/componentswithnofields/ComponentWithNoFieldsWithEventsComponentDiffDeserializer.cs b/.../tests/componentswithnofields/ComponentWithNoFieldsWithEventsComponentDiffDeserializer.cs
@@ -60,8 +60,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);
@@ -75,8 +73,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(1);
                         global::Improbable.Gdk.Tests.ComponentsWithNoFields.Empty.Serialization.Serialize(ev.Event.Payload, obj);

diff --git a/.../improbable/gdk/tests/nonblittabletypes/NonBlittableComponentComponentDiffDeserializer.cs b/.../improbable/gdk/tests/nonblittabletypes/NonBlittableComponentComponentDiffDeserializer.cs
@@ -73,8 +73,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);
@@ -88,8 +86,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(1);
                         global::Improbable.Gdk.Tests.NonblittableTypes.FirstEventPayload.Serialization.Serialize(ev.Event.Payload, obj);
@@ -105,8 +101,6 @@ public void Serialize(MessagesToSend messages, SerializedMessagesToSend serializ
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(2);
                         global::Improbable.Gdk.Tests.NonblittableTypes.SecondEventPayload.Serialization.Serialize(ev.Event.Payload, obj);

diff --git a/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/Commands/Assembly.cs b/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/Commands/Assembly.cs
@@ -19,7 +19,8 @@ public static WrappedTask<RedirectedProcessResult, AssemblyConfig> UploadAsync(A
                 config.AssemblyName,
                 "--project_name",
                 config.ProjectName,
-                "--json_output"
+                "--json_output",
+                "--enable_pre_upload_check=false",
             };
 
             if (config.ShouldForceUpload)

diff --git a/...gdk.tools/.CodeGenerator/GdkCodeGenerator/Templates/ComponentDiffDeserializerGenerator.tt b/...gdk.tools/.CodeGenerator/GdkCodeGenerator/Templates/ComponentDiffDeserializerGenerator.tt
@@ -73,8 +73,6 @@ namespace <#= qualifiedNamespace #>
                 {
                     ref readonly var update = ref updates[i];
                     var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                    // TODO: UTY-1858 - remove this workaround.
-                    schemaUpdate.GetEvents();
                     var componentUpdate = new ComponentUpdate(schemaUpdate);
                     Serialization.SerializeUpdate(update.Update, schemaUpdate);
                     serializedMessages.AddComponentUpdate(componentUpdate, update.EntityId.Id);
@@ -92,8 +90,6 @@ namespace <#= qualifiedNamespace #>
                     {
                         ref readonly var ev = ref events[i];
                         var schemaUpdate = new SchemaComponentUpdate(ComponentId);
-                        // TODO: UTY-1858 - remove this workaround.
-                        schemaUpdate.GetFields();
                         var componentUpdate = new ComponentUpdate(schemaUpdate);
                         var obj = schemaUpdate.GetEvents().AddObject(<#= ev.EventIndex #>);
                         <#= ev.FqnPayloadType #>.Serialization.Serialize(ev.Event.Payload, obj);