Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if server is using fe2 #2989

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: check if server is using fe2 #2989

merged 1 commit into from
Oct 17, 2023

Conversation

teocomi
Copy link
Member

@teocomi teocomi commented Oct 12, 2023

Adds info needed to deliver a better UX when using DU2 & FE2:

  • adds a (temporary?) frontend2 prop to the serverInfo class
  • checks against the response headers to see if a server/account is using frontend 2

@teocomi teocomi added the enhancement New feature or request label Oct 12, 2023
@teocomi teocomi mentioned this pull request Oct 12, 2023
Merged
AlanRynne
AlanRynne reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we need to unit test this too?

@teocomi
Copy link
Member Author

teocomi commented Oct 16, 2023

If the test server is using fe2 this could be easily done. Does it serve up the full frontend?

@AlanRynne
Copy link
Contributor

The current server setup does not include fe2, so I guess we can't really test this fully yet.

@AlanRynne AlanRynne merged commit 814d327 into dev Oct 17, 2023
@AlanRynne AlanRynne deleted the core/fe2-serverinfo branch October 17, 2023 15:36
@gjedlicska gjedlicska mentioned this pull request Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@JR-Morgan JR-Morgan Awaiting requested review from JR-Morgan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teocomi @AlanRynne