Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dui): better fe2 compatibility #2991

Merged
merged 5 commits into from
Oct 23, 2023
Merged

feat(dui): better fe2 compatibility #2991

merged 5 commits into from
Oct 23, 2023

Conversation

teocomi
Copy link
Member

@teocomi teocomi commented Oct 12, 2023

Depends on: #2989

This PR improves how DUI2 integrates with FE2:

  • moves the FE2 toggle to the main toolbar
  • any stream related action (eg view online) now automatically detects if a stream is on fe2 and uses the new routes
  • added more string replacements here and there

NOTE: this PR depends on some changes to Manager which are already being rolled out (current beta)

fe2-toggle

@teocomi teocomi added enhancement New feature or request desktopui issues related to the desktop ui. labels Oct 12, 2023
@teocomi teocomi requested a review from AlanRynne October 12, 2023 15:56
@AlanRynne AlanRynne self-assigned this Oct 17, 2023
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one issue, but it can be quite annoying. When adding a stream using the URL, the model(branch) that gets selected is always main even if the URL pointed to another model (see gif)

  • Selected rhino model from FE2
  • Copied URL from chrome
  • Pasted into the text box in DUI
  • Stream UI page points to the correct project but wrong model (in this case it points to. main, which i'm assuming is the default)

2023-10-17 18 06 56

@teocomi teocomi requested a review from AlanRynne October 19, 2023 09:54
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the fix!

I'll add the StreamWrapper FE2 alignment to our backlog.

@AlanRynne AlanRynne merged commit 9773ea0 into dev Oct 23, 2023
@AlanRynne AlanRynne deleted the dui/fe2-compatibility branch October 23, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktopui issues related to the desktop ui. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants