Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev with changes from main #3062

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Update dev with changes from main #3062

merged 3 commits into from
Nov 23, 2023

Conversation

AlanRynne
Copy link
Contributor

Just propagating some changes...

@JR-Morgan JR-Morgan self-requested a review November 22, 2023 16:18
jsdbroughton and others added 2 commits November 23, 2023 17:22
…#3056)

* Fix for calling Clash API and receiving nothing back.

* Refactor ConnectorNavisworksBindings.Filters.cs

- Removed unused using statement for Microsoft.CodeAnalysis.CSharp.Syntax.
- Simplified the code by removing unnecessary null checks and list initialization.
- Added a console log message to indicate that sending clashes is not supported yet.

Note: This commit does not include specific file names or mention any individuals.

* Refactor clash filter code and remove unnecessary comments

- Refactored the clash filter code in ConnectorNavisworksBindings.Filters.cs
- Removed unnecessary commented out code
* chore: Minor editorconfig changes.

* chore: Lower most Rider warnings to suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants