Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Cleanup base object serializer v2 #3065

Merged
merged 2 commits into from
Nov 30, 2023
Merged

chore(core): Cleanup base object serializer v2 #3065

merged 2 commits into from
Nov 30, 2023

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Nov 23, 2023 •
edited
Loading

In the BaseObjectSerializerV2:

  • Resolves CA2201: Do not raise reserved exception types
  • Also resolves various IDE warnings
  • I've also deprecated the unused OnErrorAction property
  • And made several other get; set; properties into read-only fields that are set by the constructor.
    This required minimal changes to our codebase, and clarifies the usage of the BaseObjectSerializerV2 class.
    The deprecation notice provides clear guidance to any third-party devs.

Merge #3062 first

@JR-Morgan JR-Morgan changed the base branch from main to dev November 23, 2023 17:06
@JR-Morgan JR-Morgan requested a review from AlanRynne November 23, 2023 17:06
@JR-Morgan JR-Morgan marked this pull request as ready for review November 23, 2023 17:06
@JR-Morgan JR-Morgan mentioned this pull request Nov 30, 2023
Merged
@AlanRynne AlanRynne changed the title chore!(core): Cleanup base object serializer v2 chore(core): Cleanup base object serializer v2 Nov 30, 2023
AlanRynne
AlanRynne approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AlanRynne AlanRynne merged commit bac754c into dev Nov 30, 2023
@AlanRynne AlanRynne deleted the jrm/core/exception-warnings branch November 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JR-Morgan @AlanRynne