chore(core): CNX-7435 Core warning reduction #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(core): IDE0005 Redundant Using statements * fix(ci): GenerateDocumentationFile is required for IDE0005 to run on CI * fix(ci): Allow warnings on all CI jobs
* fix(gh): IDE0005 for Grasshopper connector * fix(rhino): IDE0005 for Rhino connector * fix(rh/gh): IDE0005 for Rhino/Grasshopper shared converter
|
I want to give this some quick testing in some connectors and automate. All the changes I've made should be pretty innocent, but there's so many, it's worth being cautious. |
JR-Morgan
force-pushed
the
jrm/core/warning-elimination
branch
from
2343309 to
5ca04e8
Compare
JR-Morgan
force-pushed
the
jrm/core/warning-elimination
branch
from
5ca04e8 to
8449062
Compare
AlanRynne
reviewed
Dec 1, 2023
AlanRynne
reviewed
Dec 1, 2023
AlanRynne
reviewed
Dec 1, 2023
AlanRynne
reviewed
Dec 1, 2023
AlanRynne
approved these changes
Dec 1, 2023
Comment on lines
+21
to
+33
| private const int BATCH_SIZE_GET_OBJECTS = 10000; | ||
| private const int BATCH_SIZE_HAS_OBJECTS = 100000; | ||
|
|
||
| private const int MAX_MULTIPART_COUNT = 5; | ||
| private const int MAX_MULTIPART_SIZE = 25_000_000; | ||
| private const int MAX_OBJECT_SIZE = 25_000_000; | ||
|
|
||
| private const int MAX_REQUEST_SIZE = 100_000_000; | ||
|
|
||
| private const int RETRY_COUNT = 3; | ||
| private static readonly HashSet<int> s_retryCodes = new() { 408, 502, 503, 504 }; | ||
| private static readonly char[] s_separator = { '\t' }; | ||
| private static readonly string[] s_filenameSeparator = { "filename=" }; |
There was a problem hiding this comment.
We should consider moving these to a "magic numbers" class at some point, as ideally all these values should be defined by the server.
AlanRynne
changed the title
AlanRynne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves many warnings in Core
Merge first: