Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(All): Solution pass to fix formatting warnings #3068

Merged
merged 24 commits into from
Nov 28, 2023
Merged

fix(All): Solution pass to fix formatting warnings #3068

merged 24 commits into from
Nov 28, 2023

Conversation

AlanRynne
Copy link
Contributor

@AlanRynne AlanRynne commented Nov 28, 2023 •
edited
Loading

Fixes formatting and formatting related warnings:

  • Ran CSharpier on entire monorepo
  • Enforced CSharpier formatting or fail in first CI job.
  • Fixed IDE0161: File-scoped namespaces
  • Fixed IDE0090: 'new' expression can be simplified
  • Fixed IDE0011: Add braces
  • Renamed Partial Classes folder to PartialClasses in Revit and Tekla
  • Silenced Bentley and AdvanceSteel warnings on CI

@AlanRynne AlanRynne requested a review from JR-Morgan November 28, 2023 10:05
@AlanRynne AlanRynne mentioned this pull request Nov 28, 2023
Closed
@AlanRynne AlanRynne force-pushed the alan/fix/solution-warning-pass branch from 99439a5 to 3626c1d Compare November 28, 2023 10:23
@AlanRynne AlanRynne force-pushed the alan/fix/solution-warning-pass branch from 3626c1d to 875a96e Compare November 28, 2023 10:24
@AlanRynne AlanRynne merged commit 7397e53 into main Nov 28, 2023
@AlanRynne AlanRynne deleted the alan/fix/solution-warning-pass branch November 28, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JR-Morgan JR-Morgan JR-Morgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanRynne @JR-Morgan