-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add a custom admonition for Tech Preview content #2017
Conversation
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuliiiah can you make the components use a default text with the ability to override. I'd love for us to standardize on the tech preview language 😀
Looks great! @yuliiiah Can you go into each of the Preview features and change the adminition to I think these are the preview features:
Let me know if you have trouble finding these |
@karl-cardenas-coding, if I remember correctly, you, @lennessyy, and the team agreed on this wording (and it's in the style guide):
Based on this template, we want to explicitly specify what feature we're talking about, so it's not really something I can hardcode. Do you think it would be a persistent issue to copy and paste this text from the style guide? |
Do we need to name the feature? I think if we keep the language generic we'll be fine |
…h preview content
@karl-cardenas-coding I've hardcoded the tech preview text. Now, if someone wants to add this admonition, it will always render the same text, even if they try to enter something different @lennessyy I've added preview links for the pages you mentioned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic. Thank you so much for creating this 💯
Happy to help @karl-cardenas-coding :) Also, since we're already here, let me quickly remind you: https://www.merriam-webster.com/dictionary/vacation |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Hi @yuliiiah , it looks like the auto backport failed for version 4.2. Putting this on your radar in case you missed it. |
Oh wow, @lennessyy, thank you so much! I totally missed this. Will backport tomorrow once we're done with Prettier :) |
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Describe the Change
This PR includes a custom admonition for Tech Preview content.
Review Changes
💻 Nutanix
💻 Harbor Edge
💻 Vxlan Overlay
🎫 DOC-1017