Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Further Guidance admonition + link to the VMware PCG tutorial #3379

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Add the Further Guidance admonition + link to the VMware PCG tutorial #3379

merged 4 commits into from
Jul 16, 2024

Conversation

yuliiiah
Copy link
Contributor

@yuliiiah yuliiiah commented Jul 16, 2024 •
edited
Loading

Describe the Change

This PR adds the Further Guidance admonition and links to the VMware PCG tutorial from the VMware PCG guide.

Changed Pages

💻 Deploy to VMware vSphere

Jira Tickets

🎫 DOC-1290

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@yuliiiah yuliiiah added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4 labels Jul 16, 2024
@yuliiiah yuliiiah requested a review from a team as a code owner July 16, 2024 11:37
@netlify Netlify
Copy link

netlify bot commented Jul 16, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit cec3f45
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/66967a39384f5f000988151d
😎 Deploy Preview https://deploy-preview-3379--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

addetz
addetz reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@addetz addetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions but otherwise LGTM 🚀

docs/docs-content/clusters/pcg/deploy-pcg/vmware.md Outdated Show resolved Hide resolved
src/theme/Admonition/Icon/FurtherGuidance.js Outdated Show resolved Hide resolved
@yuliiiah yuliiiah merged commit 51c3f8b into master Jul 16, 2024
17 checks passed
@yuliiiah yuliiiah deleted the doc-1290 branch July 16, 2024 14:25
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
a675c93 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

(cherry picked from commit 51c3f8b)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
1592f32 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

(cherry picked from commit 51c3f8b)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 16, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- Create, style, and populate the Tutorials section (#2689)
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- chore: DOC-1148 fix missing trailing slash (#2656)
- docs: set toc_max_heading_level to default value 3 for all docs DOC-938 (#1947)
- chore: released docs versioning
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- Create, style, and populate the Tutorials section (#2689)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- chore: Add a custom admonition for Tech Preview content (#2017)
✅ version-4-3
✅ version-4-4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 3379

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
fa2d269 
…#3379) (#3381)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

(cherry picked from commit 51c3f8b)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
a0ecbcd 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review
@yuliiiah yuliiiah mentioned this pull request Jul 16, 2024
Merged
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Jul 16, 2024
@vault-token-factory-spectrocloud @yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
65f726c 
…#3379) (#3380)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

(cherry picked from commit 51c3f8b)

Co-authored-by: Yuliia Horbenko <31223054+yuliiiah@users.noreply.github.com>
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
feb8782 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review
@yuliiiah yuliiiah mentioned this pull request Jul 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
520a8e6 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review
@yuliiiah yuliiiah mentioned this pull request Jul 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
c25ac5d 
…#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review
@yuliiiah yuliiiah mentioned this pull request Jul 16, 2024
Merged
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
Add the Further Guidance admonition + link to the VMware PCG tutorial (…
2963f5b 
…#3379) (#3382)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
[version-4-1] Add the Further Guidance admonition + link to the VMwar…
6aa9090 
…e PCG tutorial (#3379) (#3383)

* Add the Further Guidance admonition + link to the VMware PCG tutorial (#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

* chore: Remove the TP admonition

* chore: Add the TP admonition
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
[version-4-0] Add the Further Guidance admonition + link to the VMwar…
e9be135 
…e PCG tutorial (#3379) (#3384)

* Add the Further Guidance admonition + link to the VMware PCG tutorial (#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

* chore: Remove the TP admonition

* chore: Add the TP admonition
yuliiiah added a commit that referenced this pull request Jul 16, 2024
@yuliiiah
[version-3-4] Add the Further Guidance admonition + link to the VMwar…
3fc06ee 
…e PCG tutorial (#3379) (#3385)

* Add the Further Guidance admonition + link to the VMware PCG tutorial (#3379)

* chore: Add the Further Guidance admonition

* docs: Link to the VMware PCG tutorial

* chore: Fix spelling

* chore: Implement peer review

* chore: Remove the TP admonition

* chore: Add the TP admonition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@addetz addetz addetz approved these changes

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

@caroldelwing caroldelwing Awaiting requested review from caroldelwing caroldelwing is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 backport-version-4-4 Backport change to version 4.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuliiiah @addetz