Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: DOC-1148 fix missing trailing slash #2656

Merged
merged 6 commits into from
Apr 16, 2024
Merged

chore: DOC-1148 fix missing trailing slash #2656

merged 6 commits into from
Apr 16, 2024

Conversation

karl-cardenas-coding
Copy link
Contributor

@karl-cardenas-coding karl-cardenas-coding commented Apr 15, 2024 •
edited
Loading

Describe the Change

This PR adds a trailing slash to URLs.

The file docusaurus.config.json now contains the trailingSlash: true entry.

Changed Pages

💻 Preview URL for Page

Jira Tickets

🎫 DOC-1148

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

@karl-cardenas-coding karl-cardenas-coding added backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 labels Apr 15, 2024
@karl-cardenas-coding karl-cardenas-coding requested a review from a team as a code owner April 15, 2024 23:13
@netlify Netlify
Copy link

netlify bot commented Apr 15, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 76c7edf
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/661eaaa74ae84a00080fda50
😎 Deploy Preview https://deploy-preview-2656--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

yuliiiah
yuliiiah approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@yuliiiah yuliiiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🚀

@karl-cardenas-coding karl-cardenas-coding merged commit 8b183a4 into master Apr 16, 2024
15 checks passed
@karl-cardenas-coding karl-cardenas-coding deleted the trailing-slash branch April 16, 2024 17:07
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656)
52c8d8e 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem

(cherry picked from commit 8b183a4)
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Apr 16, 2024
Merged
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ version-4-0 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-0:
- chore: upgrade to docusaurus 3.1.1 (#2135)
- docs: updated URLs to use file path context
❌ version-3-4 Backport failed because of merge conflicts

You might need to backport the following PRs to version-3-4:
- Refactor/restructure cluster & app profiles sections (#1551)
- docs: refactor for self-hosted Palette DOC-465 (#1597)
- docs: updated URLs to use file path context
❌ version-4-1 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-1:
- docs: DOC-1118 Image Conversion to webp (#2439)
- chore: upgrade to docusaurus 3.1.1 (#2135)
❌ version-4-2 Backport failed because of merge conflicts

You might need to backport the following PRs to version-4-2:
- chore: upgrade to docusaurus 3.1.1 (#2135)
- docs: add warning for private registry password (#2120)
- replace caution with warning (#2039)
✅ version-4-3

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 2656

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656)
3cdbbaf 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Apr 16, 2024
Merged
vault-token-factory-spectrocloud bot added a commit that referenced this pull request Apr 16, 2024
@vault-token-factory-spectrocloud @karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656) (#2667)
62f1c30 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem

(cherry picked from commit 8b183a4)

Co-authored-by: Karl Cardenas <karl@spectrocloud.com>
karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656)
7fdb7b3 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
@karl-cardenas-coding karl-cardenas-coding mentioned this pull request Apr 16, 2024
Merged
karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656)
4c21d1d 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
This was referenced Apr 16, 2024
Merged
Merged
karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656) (#2670)
d047fdd 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656) (#2668)
b4fc0f6 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
karl-cardenas-coding added a commit that referenced this pull request Apr 16, 2024
@karl-cardenas-coding
chore: DOC-1148 fix missing trailing slash (#2656) (#2669)
bc1d4a3 
* chore: DOC-1148 fix missing trailing slash

* chore: updated broken urls

* chore: more broken URLs

* docs: removed ipsum lorem
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Apr 24, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request May 7, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud
Copy link
Contributor

🎉 This PR is included in version 4.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request May 15, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Jul 8, 2024
Merged
2 tasks
This was referenced Jul 16, 2024
Merged
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Aug 2, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Aug 19, 2024
Merged
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Oct 15, 2024
Merged
1 task
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Nov 4, 2024
Merged
2 tasks
@vault-token-factory-spectrocloud vault-token-factory-spectrocloud bot mentioned this pull request Nov 22, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yuliiiah yuliiiah yuliiiah approved these changes

@lennessyy lennessyy Awaiting requested review from lennessyy lennessyy is a code owner automatically assigned from spectrocloud/docs-education

@caroldelwing caroldelwing Awaiting requested review from caroldelwing caroldelwing is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
auto-backport Enable backport backport-version-3-4 Backport change to version 3.4 backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 backport-version-4-2 Backport change to version 4.2 backport-version-4-3 Backport change to version 4.3 released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karl-cardenas-coding @yuliiiah