Rewrote MAAS custom endpoint docs #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kreeuwijk
requested review from
karl-cardenas-coding,
benradstone and
caroldelwing
✅ Deploy Preview for docs-spectrocloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
addetz
force-pushed
the
fix-maas-custom-ep
branch
from
42913b2 to
f3d32a2
Compare
addetz
added
backport-version-4-0
addetz
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Thanks for submitting this PR, @kreeuwijk! I have added a commit which makes minor tweaks to the text, but otherwise this we're good to go. 🚀
caroldelwing
approved these changes
Oct 18, 2024
docs/docs-content/clusters/data-center/maas/create-manage-maas-clusters.md
Outdated
Show resolved
Hide resolved
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
|
Thank you! |
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c)
vault-token-factory-spectrocloud bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c)
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
vault-token-factory-spectrocloud bot
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs (#4302) * Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c) * docs: fix broken link in release notes --------- Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com>
addetz
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c) Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com>
addetz
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> (cherry picked from commit 43fd77c) Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review --------- Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com> Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review --------- Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com> Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review --------- Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com> Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
addetz
added a commit
that referenced
this pull request
Oct 18, 2024
* Rewrote MAAS custom endpoint docs (#4302) * Rewrote MAAS custom endpoint docs * ci: auto-formatting prettier issues * docs: edit text to match docs style guidelines * Apply suggestions from code review Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> --------- Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: addetz <43963729+addetz@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com> * docs: undo accidental text deletion --------- Co-authored-by: Kevin Reeuwijk <kevin.reeuwijk@spectrocloud.com> Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com> Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
|
🎉 This issue has been resolved in version 4.5.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the Change
The documentation on the Custom MAAS Endpoint was wrong. This PR corrects this.
Changed Pages
💻 PXK pack
💻 MAAS Architecture
💻 Create and Manage MAAS Clusters