Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[version-3-4] Rewrote MAAS custom endpoint docs (#4302) #4341

Merged
merged 2 commits into from
Oct 18, 2024
Merged

[version-3-4] Rewrote MAAS custom endpoint docs (#4302) #4341

merged 2 commits into from
Oct 18, 2024

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Oct 18, 2024

Backport

This will backport the following commits from master to version-3-4:

@kreeuwijk @addetz @caroldelwing
Rewrote MAAS custom endpoint docs (#4302)
3b2db86 
* Rewrote MAAS custom endpoint docs

* ci: auto-formatting prettier issues

* docs: edit text to match docs style guidelines

* Apply suggestions from code review

Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>

---------

Co-authored-by: kreeuwijk <kreeuwijk@users.noreply.github.com>
Co-authored-by: addetz <43963729+addetz@users.noreply.github.com>
Co-authored-by: caroldelwing <carolina.delwing@spectrocloud.com>
@addetz addetz requested a review from a team as a code owner October 18, 2024 14:37
@addetz addetz requested review from karl-cardenas-coding, benradstone and caroldelwing and removed request for a team October 18, 2024 14:37
@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 0a26915
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/671277e63cf3cd00087291b5
😎 Deploy Preview https://deploy-preview-4341--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@addetz addetz enabled auto-merge (squash) October 18, 2024 15:10
@addetz addetz merged commit f4bee55 into version-3-4 Oct 18, 2024
7 checks passed
@addetz addetz deleted the backport/version-3-4/pr-4302 branch October 18, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-cardenas-coding karl-cardenas-coding Awaiting requested review from karl-cardenas-coding karl-cardenas-coding is a code owner automatically assigned from spectrocloud/docs-education

@benradstone benradstone Awaiting requested review from benradstone benradstone is a code owner automatically assigned from spectrocloud/docs-education

@caroldelwing caroldelwing Awaiting requested review from caroldelwing caroldelwing is a code owner automatically assigned from spectrocloud/docs-education

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addetz @kreeuwijk