Allow Blob to be passed directly when sending audio buffer (#3)

speechmatics · Sep 5, 2023 · f8da8ab · f8da8ab
1 parent 4573233
commit f8da8ab
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/src/realtime/browser.ts b/src/realtime/browser.ts
@@ -68,7 +68,7 @@ export class WebSocketWrapper implements ISocketWrapper {
     });
   }
 
-  sendAudioBuffer(buffer: ArrayBufferLike): void {
+  sendAudioBuffer(buffer: ArrayBufferLike | Blob): void {
     if (this.socket && this.isOpen()) {
       this.socket.send(buffer);
     } else console.error('Tried to send audio when socket was closed');

diff --git a/src/realtime/node.ts b/src/realtime/node.ts
@@ -71,9 +71,14 @@ export class NodeWebSocketWrapper implements ISocketWrapper {
     });
   }
 
-  sendAudioBuffer(buffer: ArrayBufferLike): void {
+  sendAudioBuffer(data: ArrayBufferLike | Blob): void {
     if (this.socket && this.isOpen()) {
-      this.socket.send(buffer);
+      if (data instanceof Blob) {
+        // NOTE: Maybe we should add a log message about this potentially being poorer performance in Node
+        data.arrayBuffer().then((buf) => this.socket?.send(buf));
+      } else {
+        this.socket.send(data);
+      }
     } else console.error('tried to send audio when socket was closed');
   }
 

diff --git a/src/types/socket-interface.ts b/src/types/socket-interface.ts
@@ -6,7 +6,7 @@ export interface ISocketWrapper {
   onDisconnect?: (event: CloseEvent) => void;
   connect(url: string, authToken?: string, appId?: string): Promise<void>;
   disconnect(): Promise<void>;
-  sendAudioBuffer(buffer: ArrayBufferLike): void;
+  sendAudioBuffer(buffer: ArrayBufferLike | Blob): void;
   sendMessage(message: string): void;
   isOpen(): boolean;
 }