Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Blob to be passed directly when sending audio buffer #3

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Allow Blob to be passed directly when sending audio buffer #3

merged 2 commits into from
Sep 5, 2023

Conversation

mnemitz
Copy link
Contributor

@mnemitz mnemitz commented Sep 4, 2023

TudorCRL
TudorCRL approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@TudorCRL TudorCRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - my one comment would be that we could maybe add a test for this, but maybe that's non trivial since this is a very context specific thing

@mnemitz mnemitz merged commit f8da8ab into main Sep 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TudorCRL TudorCRL TudorCRL approved these changes

@michalpolkowski michalpolkowski Awaiting requested review from michalpolkowski

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mnemitz @TudorCRL