-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Refactor Concurrency #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple thoughts
} | ||
} | ||
#[cfg(debug_assertions)] | ||
log::info!("{output}"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear what's happening here - but I think we want imix install to print in realtime similar to golem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not change any behavior, but currently this will print all output after evaluation. The print_stdout
is a feature flag we likely don't want enabled for imix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this?
/kind feature
What this PR does / why we need it:
eldritch::runtime::Message
and associated message types for communication between the caller and an eldritch runtime (on separate threads)file.report
API for sending files to tavernWhich issue(s) this PR fixes:
No one asked for this