Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Refactor Concurrency #599
[feature] Refactor Concurrency #599
Changes from 9 commits
74583fd
a8444c4
2e155d0
4b44ca2
01eb3d3
e2c979c
60697b8
efccf82
9de85fe
9b1bb1f
2a84f2e
b3a4786
56ab186
c0319cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 52 in implants/imix/src/agent.rs
Codecov / codecov/patch
implants/imix/src/agent.rs#L52
Check warning on line 65 in implants/imix/src/config.rs
Codecov / codecov/patch
implants/imix/src/config.rs#L65
Check warning on line 69 in implants/imix/src/config.rs
Codecov / codecov/patch
implants/imix/src/config.rs#L69
Check warning on line 76 in implants/imix/src/config.rs
Codecov / codecov/patch
implants/imix/src/config.rs#L76
Check warning on line 160 in implants/imix/src/config.rs
Codecov / codecov/patch
implants/imix/src/config.rs#L158-L160
Check warning on line 42 in implants/imix/src/install.rs
Codecov / codecov/patch
implants/imix/src/install.rs#L35-L42
Check warning on line 47 in implants/imix/src/install.rs
Codecov / codecov/patch
implants/imix/src/install.rs#L47
Check warning on line 52 in implants/imix/src/install.rs
Codecov / codecov/patch
implants/imix/src/install.rs#L50-L52
Check warning on line 56 in implants/imix/src/install.rs
Codecov / codecov/patch
implants/imix/src/install.rs#L54-L56
Check warning on line 59 in implants/imix/src/install.rs
Codecov / codecov/patch
implants/imix/src/install.rs#L59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear what's happening here - but I think we want imix install to print in realtime similar to golem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not change any behavior, but currently this will print all output after evaluation. The
print_stdout
is a feature flag we likely don't want enabled for imix.