Add adapter to allow afero.Fs usage as io/fs.FS #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It will not affect users of go older than 1.16 because files with `io/fs` import marked with build constraints
afero.Fs/File requires mutating methods implementation but they will always return error because fs.FS is read-only. ReadAt and Seek will return error if underlying fs.File doesn't implement them.
|
Released as part of https://github.com/spf13/afero/releases/tag/v1.6.0 |
Unfortunately, that's not entirely true... see golang/go#44557 I'm not saying you should revert, just that end users need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will not affect users of go older than 1.16 because files with
io/fsimport marked with build constraintsWill close #275