Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go modules to their latest versions #2379

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Update go modules to their latest versions #2379

merged 1 commit into from
Jun 2, 2021

Conversation

cfergeau
Copy link
Contributor

github.com/openshift/api and k8s/* were not touched as they usually are
trickier to update. The other openshift modules were updated to the
latest version of the release-4.7 branch.

@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@guillaumerose
Copy link
Contributor 

github.com/code-ready/crc/pkg/crc/config imports
	github.com/spf13/viper imports
	github.com/spf13/afero imports
	io/fs: package io/fs is not in GOROOT (/usr/local/go/src/io/fs)
github.com/code-ready/crc/pkg/crc/config imports
	github.com/spf13/viper imports
	github.com/spf13/afero tested by
	github.com/spf13/afero.test imports
	testing/fstest: package testing/fstest is not in GOROOT (/usr/local/go/src/testing/fstest)
make[1]: *** [vendor] Error 1
make: *** [vendorcheck] Error 2

circleci not happy, otherwise always good to update! lgtm.

@cfergeau
Copy link
Contributor Author

Apparently a bug in go versions older than 1.15.10, see spf13/afero#291 (comment) and golang/go#44557
Using afero 1.5.1 instead of 1.6.0 seems to avoid this, so I'll use that for now.

@cfergeau
Copy link
Contributor Author

cfergeau commented Jun 1, 2021

/retest

1 similar comment
@cfergeau
Copy link
Contributor Author

cfergeau commented Jun 1, 2021

/retest

praveenkumar
praveenkumar reviewed Jun 2, 2021
View reviewed changes
packaging/package.sh Outdated
sign "${binDir}/crc-driver-hyperkit"

sign "${BASEDIR}/root/Applications/CodeReady Containers.app"

codesign --verify --verbose "${binDir}/hyperkit"

sudo chmod +sx "${binDir}/hyperkit" "${binDir}/crc-admin-helper-darwin" "${binDir}/crc-driver-hyperkit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why these changes are part of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have messed up the rebase, thanks for catching it!

@cfergeau
Update go modules to their latest versions
15e1917 
github.com/openshift/api and k8s/* were not touched as they usually are
trickier to update. The other openshift modules were updated to the
latest version of the `release-4.7` branch.
@cfergeau
Copy link
Contributor Author

cfergeau commented Jun 2, 2021

/retest

@praveenkumar praveenkumar merged commit e29dd69 into crc-org:master Jun 2, 2021
@cfergeau cfergeau deleted the gomod branch September 2, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkumar praveenkumar praveenkumar left review comments

@gbraad gbraad Awaiting requested review from gbraad

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cfergeau @guillaumerose @praveenkumar