-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go modules to their latest versions #2379
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
circleci not happy, otherwise always good to update! lgtm. |
Apparently a bug in go versions older than 1.15.10, see spf13/afero#291 (comment) and golang/go#44557 |
/retest |
1 similar comment
/retest |
packaging/package.sh
Outdated
sign "${binDir}/crc-driver-hyperkit" | ||
|
||
sign "${BASEDIR}/root/Applications/CodeReady Containers.app" | ||
|
||
codesign --verify --verbose "${binDir}/hyperkit" | ||
|
||
sudo chmod +sx "${binDir}/hyperkit" "${binDir}/crc-admin-helper-darwin" "${binDir}/crc-driver-hyperkit" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why these changes are part of this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must have messed up the rebase, thanks for catching it!
github.com/openshift/api and k8s/* were not touched as they usually are trickier to update. The other openshift modules were updated to the latest version of the `release-4.7` branch.
/retest |
github.com/openshift/api and k8s/* were not touched as they usually are
trickier to update. The other openshift modules were updated to the
latest version of the
release-4.7
branch.