Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Contributor workflow] Github actions labeler doesn't work for forks #1092

Closed
jpmcb opened this issue Apr 15, 2020 · 3 comments · Fixed by #1338
Closed

[Bug][Contributor workflow] Github actions labeler doesn't work for forks #1092

jpmcb opened this issue Apr 15, 2020 · 3 comments · Fixed by #1338
Labels
kind/bug A bug in cobra; unintended behavior

Comments

@jpmcb
Copy link
Collaborator

jpmcb commented Apr 15, 2020

I've noticed that the labeler Github action isn't working. Here's an example

It looks like the actions/labeler Github action won't work with PRs opened from forks (for security reasons): actions/labeler#12

And looks like this was recently clarified: actions/labeler@2b75d22

A few workarounds:

@xchapter7x I know you looked at the labeler previously in #1074 - Any thoughts here?
@jharshman jharshman added kind/bug A bug in cobra; unintended behavior needs investigation labels Apr 16, 2020
@xchapter7x
Copy link
Contributor

seems like the periodic-labeler would wrap what we have now, and make it work as intended.

the boring-cyborg might be better long term, as it seems to have more logic and features.

id maybe implement periodic-labeler as a bugfix, and then explore future enhancements to the feature set with things like boring-cyborg or anything else that might be available in the marketplace.

xchapter7x added a commit to xchapter7x/cobra that referenced this issue Apr 21, 2020
@xchapter7x
replace labeler action with periodic-labeler
3f58c14 
this replaces the default labeler as it
does not label PRs from forks properly.

with periodic-labeler it should apply labels on
a cron to any PR and resolve the below bug:

spf13#1092
@xchapter7x xchapter7x mentioned this issue Apr 21, 2020
Merged
@xchapter7x
Copy link
Contributor

This PR should address this bug: #1097

jharshman pushed a commit that referenced this issue May 8, 2020
@xchapter7x
replace labeler action with periodic-labeler (#1097)
a7aaa7c 
* replace labeler action with periodic-labeler

this replaces the default labeler as it
does not label PRs from forks properly.

with periodic-labeler it should apply labels on
a cron to any PR and resolve the below bug:

#1092
@github-actions
Copy link

This issue is being marked as stale due to a long period of inactivity

@jpmcb jpmcb mentioned this issue Feb 5, 2021
Merged
muscliary pushed a commit to muscliary/cobra that referenced this issue Sep 12, 2023
@xchapter7x
replace labeler action with periodic-labeler (#1097)
82e74a1 
* replace labeler action with periodic-labeler

this replaces the default labeler as it
does not label PRs from forks properly.

with periodic-labeler it should apply labels on
a cron to any PR and resolve the below bug:

spf13/cobra#1092
desdeel2d0m added a commit to desdeel2d0m/cobra that referenced this issue Jul 1, 2024
@desdeel2d0m
replace labeler action with periodic-labeler (#1097)
c51b7a5 
* replace labeler action with periodic-labeler

this replaces the default labeler as it
does not label PRs from forks properly.

with periodic-labeler it should apply labels on
a cron to any PR and resolve the below bug:

spf13/cobra#1092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in cobra; unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PR labeler with pull_request_target jpmcb/cobra
3 participants
@xchapter7x @jharshman @jpmcb