Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Labeler Actions #1074

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Add Labeler Actions #1074

merged 3 commits into from
Apr 2, 2020

Conversation

xchapter7x
Copy link
Contributor

adds labeling actions
when certain parts of the code are modified by a
PR then the corresponding label is added

this will label PRs such that 
the maintainers have visibility into 
the breadth of the changes being suggested
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2020

CLA assistant check
All committers have signed the CLA.

@xchapter7x
Copy link
Contributor Author

@jharshman

@jharshman jharshman added the kind/feature A feature request for cobra; new or enhanced behavior label Apr 1, 2020
@jharshman jharshman self-requested a review April 1, 2020 16:28
"area/lib": ./*.go

# changes to the zsh completion
"area/*sh completion": ./zsh*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we match on the bash completion as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
just added the matchers for the other autocompletion shells

steps:
- uses: actions/labeler@v2
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this secret something I need to configure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe you need to do anything no.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay perfect

Copy link
Contributor

@umarcor umarcor Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, from #952 (comment):

Better integration of permissions. Since Actions is built in GitHub, it is possible to use secret tokens without explicitly managing/setting them.

By the same token, as suggested in #959, it should be possible to parse the body of PRs to have them self-labelled by contributors.

any changes to and autocomplete for any shell
will now be auto labelled as impacting the autocompletion functionality
Copy link
Collaborator

@jharshman jharshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM


# changes to the core lib package
"area/lib": ./*.go

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about one for the Cobra Generator itself?

# changes to the cobra generator
"area/cobra-generator": cobra/**/*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see that label in the current set.

Maybe we have a enhancement PR to add more labels and matchers?
@jpmcb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A feature request for cobra; new or enhanced behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants