-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add GitHub Actions workflow 'Test' #1339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you beat me to it 😆 #1340
I think we can combine our efforts. And looks like yours is much more robust (and has the latest linting PR that got merged). Although I would like to see some changes:
e08c4ec
to
2b4d7cf
Compare
Co-Authored-By: John McBride <jpmmcbride@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll merge this and we'll run both Travis CI and Github Actions side by side for now. Once we're fully confident, we can remove Travis all together!
Thanks for the changes and the thoughtful work you put into this
Travis changed their pricing model. Free resources for open source projects were significantly reduced, and maintainers need to periodically request additional "credits". Since this projects is in spf13's namespace, I guess that only he can see the state of the credits.
In practice, most open source projects are migrating from Travis CI to somewhere else, mostly GitHub Actions.
Refs: #952 #968 #1044 #1075 #1074 #1143 #1323 #1338