Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"some useful mappings" commit breaks "fastTabs" tab navigation mappings #764

Closed
toejough opened this issue May 2, 2015 · 2 comments
Closed

Comments

@toejough
Copy link
Contributor

toejough commented May 2, 2015

commit 96678bc includes mappings for H and L, which now override the preexisting mappings in .vimrc.

The pre-existing mappings allowed you to navigate among your tabs quickly with H and L.

The new mappings take you to the start and end of the line you're on. ^ or 0 and $ already did that, so my preference would be to remove the new mappings.

Pre-existing mappings (still there, just non-functional now):

if !exists('g:spf13_no_fastTabs')
        map <S-H> gT
        map <S-L> gt
    endif

New mappings:

"go to first and last char of line
    nnoremap H ^
    nnoremap L g_
    vnoremap H ^
    vnoremap L g_
toejough added a commit to toejough/spf13-vim that referenced this issue May 2, 2015
Removes the `H` and `L` mappings which conflict with the pre-existing fastTabs mappings.

Fixes spf13#764
@cpitt
Copy link

cpitt commented May 28, 2015

I would vote to just revert the changes from 96678bc , they don't add much at all

@aVolpe
Copy link

aVolpe commented May 28, 2015

Yes, please revert the changes from 96678bc, they also add the gv map to "minimize a word", when gv is the default key bind for last visual selection.

toejough added a commit to toejough/spf13-vim that referenced this issue Jun 3, 2015
Problem:
The "useful mappings" override existing, arguably *more* useful
mappings.

Analysis:
Revert the commit.
This commit reverts commit 96678bc.

Testing:
Used the old mappings successfully.

Documentation:
No change - the reverted commit did not add/modify docs.
toejough added a commit to toejough/spf13-vim that referenced this issue Jun 3, 2015
Problem:
The "useful mappings" override existing, arguably *more* useful
mappings.

Analysis:
Revert the commit.
This commit reverts commit 96678bc.

Testing:
Used the old mappings successfully.

Documentation:
No change - the reverted commit did not add/modify docs.
@spf13 spf13 closed this as completed in 9103530 Jul 16, 2015
spf13 added a commit that referenced this issue Jul 16, 2015
Summary: Fixes #764 - Revert "some useful mappings I use everyday"
theand pushed a commit to theand/spf13-vim that referenced this issue Jul 25, 2015
* commit '4f64f56019bd1627d79c2cdc1f8644517cc7ec9d':
  Summary: Fixes spf13#764 - Revert "some useful mappings I use everyday"
  Add vim with lua install instructions to readme
robbyoconnor pushed a commit to robbyoconnor/spf13-vim that referenced this issue Feb 12, 2021
Problem:
The "useful mappings" override existing, arguably *more* useful
mappings.

Analysis:
Revert the commit.
This commit reverts commit 96678bc.

Testing:
Used the old mappings successfully.

Documentation:
No change - the reverted commit did not add/modify docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants