Summary: Fixes #764 - Revert "some useful mappings I use everyday" #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
poke. @spf13 - what do you think of this pull request? |
|
+1 |
|
+1 |
Problem: The "useful mappings" override existing, arguably *more* useful mappings. Analysis: Revert the commit. This commit reverts commit 96678bc. Testing: Used the old mappings successfully. Documentation: No change - the reverted commit did not add/modify docs.
|
anyone with merge permissions want to merge this? Or comment as to why you don't want to merge it? It's a pretty small update, to revert some keybindings that override other keybindings that occur earlier in the rc. |
spf13
added a commit
that referenced
this pull request
Jul 16, 2015
Summary: Fixes #764 - Revert "some useful mappings I use everyday"
|
Apologize for the delay.. DockerCon/GopherCon/OSCON have been quite all encompassing of my time. Merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The "useful mappings" override existing, arguably more useful
mappings.
Analysis:
Revert the commit.
This commit reverts commit 96678bc.
Testing:
Used the old mappings successfully.
Documentation:
No change - the reverted commit did not add/modify docs.