Handle ConnectionError on HTTP HEAD Requests #9308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rammar-fix doc: Fix grammar in documentation for `autodoc_typehints`
Remove unnecesary sleep when submitting parallel tasks
Recommend MyST-Parser for Markdown usage
* Remove `div.doctest` so that the selecting feature in snippets code are not just available for doctests snippets
C++, add internal API for setting name in ASTType
Add `mathjax3_config` config option
This seems to have been a mistake with sphinx-doc#4022 the ajax call functions correctly without the source files being included in the build (they are never used). I have tested this out on several themes and now everything works correctly with `html_copy_source = False`
There is no docs and testcases for "None" argument of the program directive. It has been implemented since very old version. But it's not documented and tested long.
Since checkmark already exists, it makes sense to have this too. Both signs are used as "yes" or "no" replacements in text UIs.
…ultiplication Add unicode multiplication to texescape
Add doc and testcase for program directive (refs: sphinx-doc#9137)
…e_not_having_comment Fix sphinx-doc#9283: autodoc: failed to build doc for attribute not commented
Co-authored-by: François Freitag <mail@franek.fr>
Except for py which has mixins that assumes a single pending_xref
The err role doesn't exist and the rest are all equivalent.
…_anchors Close sphinx-doc#9016: linkcheck builder failed to check the anchors of github.com
Call roles in typed fields
…ctor Refactor C and C++ tests
Update message catalogs
fix: Fix typo in add_directive docstring
doc: Fix docslint misunderstanding scope of code-blocks
|
Wrong branch, opened #9309 to replace this. |
@elmayana00 I messed up this PR by selecting branches 4.x to 4.0.x. #9309 is the clean PR that's 4.0.x to 4.0.x. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Resolves #9306
Feature or Bugfix
Purpose
make linkcheckto fail on URLs that will open and render properly in a web browser. Prior to this fix, the link checker would incorrectly call these links broken.Detail
HTTP HEADrequests, but will return the requested document forHTTP GETrequests. Thelinkcheck.pycode wasn't catching theConnectionErrorexception, and as a result the code would skip therequests.get()attempt. With this fix, ifrequests.head()raises aConnectionError, it will attempt arequests.get()which, for the UT Patent website, succeeds. If the website truly is rejecting all connections, an exception on therequests.get()call will still send control to theexcept Exception as errblock as before.Relates