-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sphinx as a required dependency #15
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
0032624
to
32d5a29
Compare
3415bc0
to
b8dc42f
Compare
Gentle reminder to get this in. We are also hampered by the circular dependency (using pipdeptree). |
Signed-off-by: Ryan Northey <ryan@synca.io> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AA-Turner Please revert, the dep is needed, it has broken our CIs:
|
You're using Sphinx v4.5.0, which is no longer supported -- if you require Sphinx 4 still, you'll have to pin dependencies. A |
@AA-Turner let's do a Sphinx 4.5.1 patch release then fix with https://github.com/sphinx-doc/sphinx/blob/v4.5.0/setup.py#L17 line changed to: - 'sphinxcontrib-applehelp',
+ 'sphinxcontrib-applehelp<=1.0.4', in 5.x, 6.x, 7.x this needs to be done too to prevent simillar issue in the future |
CI got broken as the sphinxcontrib.applehelp extension was changed to require Sphinx version 5.0.0+ in patch bump here: sphinx-doc/sphinxcontrib-applehelp#15 Dependencies have been bumped to fix this. This slightly changes some styling, file name styling in code block captions is a little broken, will need to fix later. Did not do much in-depth investigation if anything else is broken, but skimmed through most pages and they look fine.
CI got broken as the sphinxcontrib.applehelp extension was changed to require Sphinx version 5.0.0+ in patch bump here: sphinx-doc/sphinxcontrib-applehelp#15 Dependencies have been bumped to fix this. This slightly changes some styling, file name styling in code block captions is a little broken, will need to fix later. Did not do much in-depth investigation if anything else is broken, but skimmed through most pages and they look fine.
No description provided.