Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sphinx as a required dependency #15

Merged
merged 6 commits into from
Jan 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install .[test]
python -m pip install .[test,standalone]

- name: Test with pytest
run: python -m pytest -vv --durations 25
Expand Down
7 changes: 7 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
Release 1.0.7 (unreleased)
==========================

* Remove Sphinx as a required dependency, as circular dependencies may cause
failure with package managers that expect a directed acyclic graph (DAG)
of dependencies.

Release 1.0.6 (2023-08-09)
==========================

Expand Down
7 changes: 4 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,7 @@ classifiers = [
"Topic :: Text Processing",
"Topic :: Utilities",
]
dependencies = [
"Sphinx>=5",
]
dependencies = []
dynamic = ["version"]
AA-Turner marked this conversation as resolved.
Show resolved Hide resolved

[project.optional-dependencies]
Expand All @@ -53,6 +51,9 @@ lint = [
"mypy",
"docutils-stubs",
]
standalone = [
"Sphinx>=5",
]

[[project.authors]]
AA-Turner marked this conversation as resolved.
Show resolved Hide resolved
name = "Georg Brandl"
Expand Down
1 change: 1 addition & 0 deletions sphinxcontrib/applehelp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ def do_codesign(self) -> None:


def setup(app: Sphinx) -> dict[str, Any]:
app.require_sphinx('5.0')
app.setup_extension('sphinx.builders.html')
app.add_builder(AppleHelpBuilder)
app.add_message_catalog(__name__, path.join(package_dir, 'locales'))
Expand Down