maint(ct): Fix test broken by Foundry update #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
RPate97
commented
Apr 18, 2024
| @@ -209,6 +209,6 @@ contract ManagedService_Test is Test, ManagedService { | |||
|
|
|||
| function test_RevertIfOwnerIsAddressZero() external { | |||
| vm.expectRevert("ManagedService: admin cannot be address(0)"); | |||
| new ManagedService{ salt: keccak256("1") }(address(0)); | |||
There was a problem hiding this comment.
The update to Foundry to use the create2 factory in the simulation caused this test to break since the error if the create2 factory is used differs from the error we expect on line 211. I resolved this issue just by deploying via the normal create opcode.
For reference, this is the result if the create2 factory is used:
sam-goldman
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes a minor issue in one of our tests that was introduced by this PR in Foundry. This issue does not effect our service for any users.