Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint(ct): Fix test broken by Foundry update #1687

Merged
merged 1 commit into from
Apr 19, 2024
Merged

maint(ct): Fix test broken by Foundry update #1687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/contracts/test/ManagedService.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,6 @@ contract ManagedService_Test is Test, ManagedService {

function test_RevertIfOwnerIsAddressZero() external {
vm.expectRevert("ManagedService: admin cannot be address(0)");
new ManagedService{ salt: keccak256("1") }(address(0));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to Foundry to use the create2 factory in the simulation caused this test to break since the error if the create2 factory is used differs from the error we expect on line 211. I resolved this issue just by deploying via the normal create opcode.

For reference, this is the result if the create2 factory is used:
Screenshot 2024-04-18 at 3 55 21 PM

new ManagedService(address(0));
}
}