chore(buildtool): Auto-deprecate old Spinnaker versions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff.
|
@spinnakerbot cherry-pick 1.19 |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff.
|
Cherry pick successful: #55 |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff.
|
Cherry pick successful: #56 |
spinnakerbot
pushed a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff.
|
Cherry pick successful: #57 |
ezimanyi
added a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff. Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
ezimanyi
added a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff. Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
ezimanyi
added a commit
that referenced
this pull request
Mar 20, 2020
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil. This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.) This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff. Co-authored-by: Eric Zimanyi <ezimanyi@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publish_changelog function in the buildtool currently publishes a new changelog for the newly-released Spinnaker version. After publishing a patch version, the release manager needs to manually edit the spinnaker.github.io repository to deprecate the prior patch version, which is unnecessary manual toil.
This change updates the publish_changelog so that, in addition to publishing a new changelog, it also deprecates the changelog corresponding to the prior patch release. If this is the first patch release of a minor version, it will short-circuit and will not deprecate anything. (Maybe at some point we could update it to deprecate the last patch release of the N-3 minor version but for now that will stay manual.)
This also adds a newline at the end of each generated changelog, as this always gets added when eventually deprecating it (whether manually or via this script), increasing the diff.