Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(buildtool): Auto-deprecate old Spinnaker versions (#43) #57

Conversation

spinnakerbot
Copy link
Collaborator

The publish_changelog function in the buildtool currently
publishes a new changelog for the newly-released Spinnaker version.
After publishing a patch version, the release manager needs to
manually edit the spinnaker.github.io repository to deprecate the
prior patch version, which is unnecessary manual toil.

This change updates the publish_changelog so that, in addition to
publishing a new changelog, it also deprecates the changelog
corresponding to the prior patch release. If this is the first
patch release of a minor version, it will short-circuit and will
not deprecate anything. (Maybe at some point we could update it
to deprecate the last patch release of the N-3 minor version but
for now that will stay manual.)

This also adds a newline at the end of each generated changelog,
as this always gets added when eventually deprecating it (whether
manually or via this script), increasing the diff.

Automated cherry pick of 1c94dcf into 1.17

The publish_changelog function in the buildtool currently
publishes a new changelog for the newly-released Spinnaker version.
After publishing a patch version, the release manager needs to
manually edit the spinnaker.github.io repository to deprecate the
prior patch version, which is unnecessary manual toil.

This change updates the publish_changelog so that, in addition to
publishing a new changelog, it also deprecates the changelog
corresponding to the prior patch release. If this is the first
patch release of a minor version, it will short-circuit and will
not deprecate anything. (Maybe at some point we could update it
to deprecate the last patch release of the N-3 minor version but
for now that will stay manual.)

This also adds a newline at the end of each generated changelog,
as this always gets added when eventually deprecating it (whether
manually or via this script), increasing the diff.
@ezimanyi ezimanyi merged commit 4108511 into release-1.17.x Mar 20, 2020
@ezimanyi ezimanyi deleted the auto-cherry-pick-1.17-1c94dcf72266a927a50a7c03a333c5aa2ec82aa7 branch March 20, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants