refactor(cloudfoundry): move processes into their own services #5316
Conversation
update master
update master
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
|
|
||
| @GET("/v3/processes/{guid}/stats") | ||
| Call<ProcessResources> findProcessStatsById(@Path("guid") String guid); | ||
|
|
There was a problem hiding this comment.
Is the plan to move other methods to different interfaces (like one interface for routes, one for packages, etc)?
There was a problem hiding this comment.
I think as they get big enough it makes sense. Overall I think our nomenclature should be as similar to the cloud foundry api as possible. Another example, I renamed "scaleApplication" to "scaleProcess" since thats actually whats happening (v3/processes/:guid/actions/scale). That could cause confusion for someone looking at it for the first time if they don't have the context
| @Override | ||
| public Logs getLogs() { | ||
| return logs; | ||
| } |
This is a refactor to move processes and their operations into process specific classes for code cleanliness and readability. This also maps more closely with the cloud foundry api model. No new logic and no changes to existing logic.