Initial titan integration #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| TitanClient getTitanClient(String account, String region) { | ||
| TitanEndpoint titanEndpoint = new TitanEndpoint(account, region) | ||
| TitanClientFactory.newInstance(titanEndpoint) |
There was a problem hiding this comment.
I'd expect to see something like this done in a DI friendly manner
|
I'd like to see this cleaned up quite a bit more before it hits master - first pass through it looks very copied and pasted from the AWS implementation and I'd like to make sure stuff isn't coming along for the ride from that where it doesn't make sense. Also will need some tests in here... |
added 2 commits
July 6, 2015 15:03
Conflicts: settings.gradle
|
added 16 commits
July 27, 2015 18:35
… InstanceCachingAgent
Conflicts: settings.gradle
Conflicts: clouddriver-web/src/main/groovy/com/netflix/spinnaker/clouddriver/Main.groovy settings.gradle
…updated the TitanServerGroup and TitanInstance model classes.
duftler
pushed a commit
that referenced
this pull request
Nov 13, 2015
update unixScript.text template file
tomaslin
pushed a commit
to tomaslin/clouddriver
that referenced
this pull request
Sep 11, 2018
…essor Introduce ApplicationSpecificIamRoleDescriptionPreProcessor
tomaslin
pushed a commit
to tomaslin/clouddriver
that referenced
this pull request
Sep 11, 2018
…-iam-role-tagging to master * commit '70dae3ffca5a416dfe28d9edeb201d152ef11a1e': Support for restricting the set of users that can tag an iam role
luba239
pushed a commit
to vasiliy-briginets/clouddriver
that referenced
this pull request
Mar 5, 2020
Update .gitignore.
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
Move config from halyard-web to halyard-config
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
* Adding openstack bakery (#3) Adding Openstack Bakery commands to halyard h/t @shazy792 @dylanbernhardt @MatthewKohner @msilpala * fix openstack bakery commands (spinnaker#4) * fix formatting (spinnaker#5) * Remove unused imports and some extra spaces. (spinnaker#6) * fix virtualization settings for openstack base image (spinnaker#7) * fix formatting * fix virtualization settings for openstack base image * Bakery Options finishing touches (spinnaker#8) * remove extraneous if * fix intellij formatting * Make bakery insecure parameter nullable * remove commented out line * remove OpenstackBakeryDefaults null setting and make insecure required setting so vaildation works
This was referenced Dec 3, 2020
kirangodishala
added a commit
to kirangodishala/clouddriver
that referenced
this pull request
May 10, 2022
Moved all the classes from groovy to java.
sanopsmx
pushed a commit
to sanopsmx/clouddriver
that referenced
this pull request
May 1, 2023
Fixed build issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial draft. This module can be disabled by setting the
titan.enabledproperty to false.