Fix for multiple subnets per zone when creating load balancers #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a totally legitimate AWS configuration
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Mar 11, 2020
* Adding openstack bakery (#3) Adding Openstack Bakery commands to halyard h/t @shazy792 @dylanbernhardt @MatthewKohner @msilpala * fix openstack bakery commands (spinnaker#4) * fix formatting (spinnaker#5) * Remove unused imports and some extra spaces. (spinnaker#6) * fix virtualization settings for openstack base image (spinnaker#7) * fix formatting * fix virtualization settings for openstack base image * Bakery Options finishing touches (spinnaker#8) * remove extraneous if * fix intellij formatting * Make bakery insecure parameter nullable * remove commented out line * remove OpenstackBakeryDefaults null setting and make insecure required setting so vaildation works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We configure multiple subnets for each AZ for a number of reasons. On an ASG it just works, but an ELB still only allows selection of one subnet per zone. Our strategy is to just to randomly pick one subnet from the available set.
This change also includes as a separate commit deletion of a swath of unused methods in the
SubnetAnalyzerclass. That was lift-n-shifted from the Asgard codebase without paring out the bits that we don't care about.@spinnaker/netflix-reviewers PTAL