Arm64 support #5767
Merged
Arm64 support #5767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adapt Dockerfile.slim to choose binaries based on TARGETARCH - install gcloud via wget&tar on ubuntu. Even the latest ubuntu doesn't contain google-cloud-sdk-app-engine-java/-go for arm64 in the repositories
Motivation: Allow running & experimenting with Spinnaker locally on Macbok M1. Relevant docs: https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md Similar MR: spinnaker/rosco#886
|
About the "Validate Gradle Wrapper" failure - gradle wrapper wasn't changed in this MR. I've manually verified the checksum for gradle-wrapper.jar and it matches the one published here: https://services.gradle.org/versions/all There's an open issue about spurious failures for this github action: gradle/wrapper-validation-action#57 |
dbyron-sf
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build docker images for multiple architectures
Motivation:
Allow running & experimenting with Spinnaker locally on Macbok M1.
Relevant docs:
https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md
Similar MR:
spinnaker/rosco#886