Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 support #886

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Arm64 support #886

merged 3 commits into from
Jun 9, 2022

Conversation

mflis
Copy link
Contributor

@mflis mflis commented Jun 9, 2022

Changes that allow building Rosco images for both amd64 and arm64 architectures. That's the first of many PRs to various Spinnaker Components that allow building docker images for multiple architectures.

Motivation:
Allow running & experimenting with Spinnaker locally on Macbok M1.

Changes:

  • Choose binaries in docker build based on the target architecture
  • bump Kustomize to a version that contains arm64 binaries
  • update Github action to build multiple architectures

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 8e9530f: Enable multi architecture builds

  • 51e7a27: Build docker images for multiple architectures

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Marcin Flis added 2 commits June 9, 2022 14:29
- Choose binaries in docker build based on target architecture
- bump Kustomize to version that contains arm64 binaries
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Jun 9, 2022
@mergify mergify bot added the auto merged label Jun 9, 2022
@mergify mergify bot merged commit 2253c9e into spinnaker:master Jun 9, 2022
@dbyron-sf
Copy link
Contributor

@mflis after merging this the build that runs on master failed: https://github.com/spinnaker/rosco/runs/6821708648?check_suite_focus=true . Mind taking a look?

Copy link
Contributor

@kskewes-sf kskewes-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, paves the way for better local development on newer arch and also experimenting with other instance types available from cloud providers.

.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
mflis added a commit to mflis/echo that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/fiat that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/front50 that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/gate that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/igor that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/deck that referenced this pull request Aug 8, 2022
Motivation:
Allow running & experimenting with Spinnaker locally on Macbok M1.

Relevant docs:
https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md

Similar MR:
spinnaker/rosco#886
mflis added a commit to mflis/orca that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/keel that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/kayenta that referenced this pull request Aug 8, 2022
mflis added a commit to mflis/deck that referenced this pull request Aug 8, 2022
mergify bot pushed a commit to spinnaker/echo that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/kayenta that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/keel that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/orca that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/gate that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/igor that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/deck that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/fiat that referenced this pull request Aug 13, 2022
mergify bot pushed a commit to spinnaker/front50 that referenced this pull request Aug 13, 2022
mflis added a commit to mflis/clouddriver that referenced this pull request Aug 16, 2022
mergify bot pushed a commit to spinnaker/clouddriver that referenced this pull request Aug 16, 2022
* chore(dockerfile): Adapt Dockerfiles to build for arm64

- adapt Dockerfile.slim to choose binaries based on TARGETARCH
- install gcloud via wget&tar on ubuntu. Even the latest ubuntu doesn't
  contain google-cloud-sdk-app-engine-java/-go for arm64 in the
  repositories

* chore(build): Build docker images for multiple architectures

Motivation:
Allow running & experimenting with Spinnaker locally on Macbok M1.

Relevant docs:
https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md

Similar MR:
spinnaker/rosco#886
mflis added a commit to mflis/halyard that referenced this pull request Aug 18, 2022
mergify bot added a commit to spinnaker/halyard that referenced this pull request Aug 18, 2022
Motivation:
Allow running & experimenting with Spinnaker locally on Macbok M1.

Relevant docs:
https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md

Similar MR:
spinnaker/rosco#886

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
opsmxuser pushed a commit to OpsMx/gate that referenced this pull request Sep 30, 2022
osoriano pushed a commit to osoriano/keel that referenced this pull request Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants