fix(artifacts): method-syntax functions cant be used as constructors (#…

…5269)
spinnaker · May 4, 2018 · 5aee5c0 · 5aee5c0
1 parent 41fb7a3
commit 5aee5c0
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 11 deletions.
diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/base64/base64.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/base64/base64.artifact.ts
@@ -14,7 +14,7 @@ module(BASE64_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigProvid
     key: 'base64',
     isDefault: false,
     isMatch: true,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'embedded/base64';

diff --git a/...ipts/modules/core/src/pipeline/config/triggers/artifacts/base64/defaultBase64.artifact.ts b/...ipts/modules/core/src/pipeline/config/triggers/artifacts/base64/defaultBase64.artifact.ts
@@ -21,7 +21,7 @@ module(DEFAULT_BASE64_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConf
     key: 'default.base64',
     isDefault: true,
     isMatch: false,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'embedded/base64';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/custom/custom.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/custom/custom.artifact.ts
@@ -19,7 +19,7 @@ module(CUSTOM_ARTIFACT, [PIPELINE_CONFIG_PROVIDER])
       key: 'custom',
       isDefault: true,
       isMatch: true,
-      controller(artifact: IArtifact) {
+      controller: function(artifact: IArtifact) {
         'ngInject';
         this.artifact = artifact;
       },

diff --git a/...ipts/modules/core/src/pipeline/config/triggers/artifacts/docker/defaultDocker.artifact.ts b/...ipts/modules/core/src/pipeline/config/triggers/artifacts/docker/defaultDocker.artifact.ts
@@ -13,7 +13,7 @@ module(DEFAULT_DOCKER_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConf
     isMatch: false,
     description: 'A Docker image to be deployed.',
     key: 'default.docker',
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'docker/image';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/docker/docker.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/docker/docker.artifact.ts
@@ -12,7 +12,7 @@ module(DOCKER_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigProvid
     isMatch: true,
     description: 'A Docker image to be deployed.',
     key: 'docker',
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'docker/image';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gcs/defaultGcs.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gcs/defaultGcs.artifact.ts
@@ -13,7 +13,7 @@ module(DEFAULT_GCS_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigP
     key: 'default.gcs',
     isDefault: true,
     isMatch: false,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'gcs/object';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gcs/gcs.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/gcs/gcs.artifact.ts
@@ -12,7 +12,7 @@ module(GCS_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigProvider:
     key: 'gcs',
     isDefault: false,
     isMatch: true,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'gcs/object';

diff --git a/...ipts/modules/core/src/pipeline/config/triggers/artifacts/github/defaultGithub.artifact.ts b/...ipts/modules/core/src/pipeline/config/triggers/artifacts/github/defaultGithub.artifact.ts
@@ -12,7 +12,7 @@ module(DEFAULT_GITHUB_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConf
     key: 'default.github',
     isDefault: true,
     isMatch: false,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'github/file';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/github/github.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/github/github.artifact.ts
@@ -12,7 +12,7 @@ module(GITHUB_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigProvid
     key: 'github',
     isDefault: false,
     isMatch: true,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 'github/file';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/s3/defaultS3.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/s3/defaultS3.artifact.ts
@@ -13,7 +13,7 @@ module(DEFAULT_S3_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigPr
     key: 'default.s3',
     isDefault: true,
     isMatch: false,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 's3/object';

diff --git a/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/s3/s3.artifact.ts b/app/scripts/modules/core/src/pipeline/config/triggers/artifacts/s3/s3.artifact.ts
@@ -12,7 +12,7 @@ module(S3_ARTIFACT, [PIPELINE_CONFIG_PROVIDER]).config((pipelineConfigProvider:
     key: 's3',
     isDefault: false,
     isMatch: true,
-    controller(artifact: IArtifact) {
+    controller: function(artifact: IArtifact) {
       'ngInject';
       this.artifact = artifact;
       this.artifact.type = 's3/object';

diff --git a/tslint.json b/tslint.json
@@ -44,6 +44,7 @@
     "no-var-keyword": true,
     "object-curly-spacing": "always",
     "object-literal-sort-keys": false,
+    "object-literal-shorthand": false,
     "one-line": [true, "check-catch", "check-else", "check-open-brace", "check-whitespace"],
     "prefer-const": [true, { "destructuring": "all" }],
     "quotemark": [true, "single", "avoid-escape", "jsx-double"],