fix(artifacts): method-syntax functions cant be used as $controller constructors #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
ping @anotherchrisberry just for interest's sake |
ezimanyi
approved these changes
May 4, 2018
danielpeach
approved these changes
May 4, 2018
|
moved lint change to tslint.json |
|
Good catch, thanks @sbwsg |
amanya
pushed a commit
to amanya/deck
that referenced
this pull request
Jul 25, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly oblique side effect of today's transpiler change. Functions defined using "method syntax" previously were changed into
function() { }declarations but are now not transformed, instead relying on the browser's native support for methods. Functions defined using method syntax are not allowed to be used as constructors [1] but previously this was not being enforced by the transpiled method declarations.Angular's $controller service attempts to use the functions passed in from artifact modules'
controllerprop as constructors. Because they were defined using method syntax, they threw errors after the transpiler change.[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions#Method_definitions_are_not_constructable