Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appengine): move config template into html file #5870

Merged
1 commit merged into from Oct 19, 2018
Merged

feat(appengine): move config template into html file #5870

1 commit merged into from Oct 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2018

This PR just moves a string template into an HTML file. Upcoming PR makes modifications to the template but I didn't want to mix logic change with this diff noise.

@ghost ghost requested review from danielpeach and maggieneterval October 19, 2018 19:39
@ghost ghost merged commit bdca8aa into spinnaker:master Oct 19, 2018
@ghost ghost deleted the gae-config-files-template branch October 19, 2018 19:57
gcomstock pushed a commit to gcomstock/deck that referenced this pull request Dec 3, 2018
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (spinnaker#6667)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (spinnaker#6347)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280)
8cef885 fix(appengine): move artifact account dropdown below radio buttons (spinnaker#6255)
6b8188b chore(*): Add core alias to module tsconfigs
c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (spinnaker#5908)
351d4fb feat(appengine): unflag container image url deployments (spinnaker#5894)
0a6d3f9 feat(provider/appengine): enable artifacts as config files (spinnaker#5888)
bdca8aa feat(appengine): move config template into html file (spinnaker#5870)
christopherthielen added a commit that referenced this pull request Jun 5, 2019
e2b4d8e refactor(*): remove unused local storage caches (#6665)
49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (#6667)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280)
8cef885 fix(appengine): move artifact account dropdown below radio buttons (#6255)
6b8188b chore(*): Add core alias to module tsconfigs
c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (#5908)
351d4fb feat(appengine): unflag container image url deployments (#5894)
0a6d3f9 feat(provider/appengine): enable artifacts as config files (#5888)
bdca8aa feat(appengine): move config template into html file (#5870)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants