fix(core): Child pipeline should route back correctly #6586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Feb 20, 2019
| @@ -55,6 +55,14 @@ module(PIPELINE_STATES, [APPLICATION_STATE_PROVIDER]).config( | |||
| views: { | |||
| pipelines: { component: SingleExecutionDetails, $type: 'react' }, | |||
| }, | |||
| params: { | |||
There was a problem hiding this comment.
You can pass a complex object as a single parameter, i.e,
params: {
sender: null
}
There was a problem hiding this comment.
I like that. I will update it.
| @@ -128,6 +128,9 @@ export class SingleExecutionDetails extends React.Component< | |||
| public render() { | |||
| const { app } = this.props; | |||
| const { execution, sortFilter, stateNotFound } = this.state; | |||
| let { senderApplication: application, senderExecutionId: executionId } = ReactInjector.$state.params; | |||
There was a problem hiding this comment.
If you pass an object in the params such as executionParams, then you could do:
const defaultExecutionParams = { application: app.name, executionId: execution && execution.id };
const executionParams = ReactInjector.$state.params.executionParams || defaultExecutionParams;
and then use executionParams in the sref:
<UISref to="^.executions.execution" params={executionParams}>
| @@ -55,6 +55,14 @@ module(PIPELINE_STATES, [APPLICATION_STATE_PROVIDER]).config( | |||
| views: { | |||
| pipelines: { component: SingleExecutionDetails, $type: 'react' }, | |||
| }, | |||
| params: { | |||
| senderApplication: { | |||
There was a problem hiding this comment.
the name sender seems ambigious to me, how about something like executionParams
archana-s
force-pushed
the
fix/childPipelines
branch
from
84d55d4
to
cee653c
Compare
anotherchrisberry
added a commit
that referenced
this pull request
Feb 21, 2019
…75 and titus to 0.0.75 (#6593) * chore(core): Bump version to 0.0.337 d853827 fix(core): Child pipeline should route back correctly (#6586) bc9a30b fix(core): allow selecting accounts via simple select field in AccountSelectInput (#6592) 4b91b36 refactor(core): move Ace Editor CSS to core module (#6588) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569) * chore(docker): Bump version to 0.0.34 b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points aa4e8df fix(eslint): Fix eslint warnings for @typescript-eslint/ban-types * chore(amazon): Bump version to 0.0.175 cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points 4f1c5c3 feat(aws): allow override of scaling policies section (#6584) cabc667 fix(aws): prevent clone submit when ingress rule removal in not acked (#6577) * chore(titus): Bump version to 0.0.75 cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points aa4e8df fix(eslint): Fix eslint warnings for @typescript-eslint/ban-types ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child pipeline in different application should route back to the initiating pipeline/application.
With growing number of teams that create an application only with pipelines, the number of pipeline stages that point to pipelines in other applications have increased. When someone navigates from a parent pipeline to a child pipeline execution through the pipelineStage, the back arrow takes the user back to the current application executions. However this can be annoying for users who landed here from other applications. This diff fixes where the back arrow takes the user.