Fixes XSS vulnerability with default Spring error attributes #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. People certainly expect 404 but I don't expect there to be an issue with the path attribute being stripped out. As long as the retrofit exception mapper continues to work (and it sounds like it does), I'm happy. |
ttomsu
pushed a commit
that referenced
this pull request
Oct 20, 2015
Fixes XSS vulnerability with default Spring error attributes
Closed
Closed
Closed
Closed
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
May 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates same fix from spinnaker/orca#588 to Gate
@ajordens , @anotherchrisberry - I looked across Deck, and nothing looks to explicitly use the 'path' element. Do you know of any internal users who script against Gate that, for whatever reason, expect 404 errors?
@duftler FYI