Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.0.4.2 #1796

Closed
wants to merge 749 commits into from
Closed

V4.0.4.2 #1796

wants to merge 749 commits into from

Conversation

tejaambati25
Copy link

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

ramyaravi-opsmx and others added 30 commits January 6, 2022 12:46
…sapor. (#117)

* OP-11837: Passing cookie to dashboard.

* OP-11837: Passing cookie in the header

* OP-11837: Added cookie to update gate api

* OP-11837: Added cookie to delete gate api

* OP-11837: Added cookie to delete gate api
…m and SAPOR (#120)

* OP-11496 : Added Maping URL for pagination APIs in dashboard, platform and SAPOR

* OP-11496 : Updated service class queries

* OP-11496 : Modified code

* OP-11496 : Modified code
* OP-11837: Added external gate

* OP-11837: added log

* OP-11837: removed log
Op 11594 application auth RBAC added for dashboard service APIs
vivek-opsmx and others added 26 commits October 3, 2023 15:41
* Added alertMessage param in post URL

* Added semgrep param in download url
…API's and Publish user details as events to rabbitmq. (#427)
OP-21271 : Added new query param for tags for the alerts APIs
OP-21271 : Added tags query param
* OP-21361 : Unprotected ssd API for spinnaker webhook
OP-21372 : Added url mapping query param action
@spinnakerbot
Copy link
Contributor

Please delete the pull request instructions from the body of your pull request message.

The instructions start with the line:

We prefer small, well tested pull requests.

You can reopen your pull request when this has been addressed.

@spinnakerbot
Copy link
Contributor

We prefer that non-test backend code be written in Java or Kotlin, rather than Groovy. The following files have been added and written in Groovy:

  • gate-core/src/main/groovy/com/netflix/spinnaker/gate/model/PermissionModel.groovy

  • gate-core/src/main/groovy/com/netflix/spinnaker/gate/services/OesAuthorizationService.groovy

  • gate-core/src/main/groovy/com/netflix/spinnaker/gate/services/OesPermissionService.groovy

  • gate-core/src/main/java/com/netflix/spinnaker/gate/services/UserDataService.groovy

  • gate-file/src/main/groovy/com/netflix/spinnaker/gate/security/file/FileSsoConfig.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxAuthController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxAutopilotController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxDashboardController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxOesController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxPlatformController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxSsdController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxSsdOpaController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/OpsmxVisibilityController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/controllers/TokenAuthController.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/model/ApprovalGateTriggerResponseModel.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/model/RegisterCanaryResponseModel.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/UserInfoService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxAutopilotService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxDashboardService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxOesService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxPlatformService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxSsdOpaService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxSsdService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/OpsmxVisibilityService.groovy

  • gate-web/src/main/groovy/com/netflix/spinnaker/gate/services/internal/RoscoService.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/controllers/OpsmxAuditClientServiceController.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/controllers/OpsmxAuditServiceController.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/controllers/OpsmxSaporPolicyController.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/controllers/OpsmxSessionController.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/exception/ErrorResponseModel.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/exception/RetrofitErrorHandler.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/services/OpsmxAuditClientService.groovy

  • gate-web/src/main/groovy/com/opsmx/spinnaker/gate/services/OpsmxAuditService.groovy

See our server-side conventions here.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.