Multi-auth with X509 and OAuth2 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static String emailFromSubjectAlternativeName(X509Certificate cert) { | ||
| cert.getSubjectAlternativeNames().find { | ||
| it.find { it.toString() == RFC822_NAME_ID } | ||
| }?.get(1) |
There was a problem hiding this comment.
What are the side effects if this returns null?
There was a problem hiding this comment.
token.principal is used - see L51
|
LGTM. Hopefully we can make configuring this multi-auth cleaner in the future while still leveraging spring-security... |
Pranav-b-7
referenced
this pull request
in OpsMx/gate
May 25, 2021
OP-5952 : Added new autopilot endpoints
Closed
Closed
Closed
Closed
kirangodishala
pushed a commit
to kirangodishala/gate
that referenced
this pull request
May 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtk54 PTAL
@rwinch, @ajordens FYI