fix(oauth): Fix UnsatifiedDependencyException #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the ExternalSslAwareEntryPoint component is being created even though the outer class has a ConditionalOnExpression which returns false. I guess as it is a different class found by spring on startup and it doesn't consider it related to the outer class. So i've simply duplicated the ConditionalOnExpression from the outer class to ExternalSslAwareEntryPoint.
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
It looks like the ExternalSslAwareEntryPoint component is being created even though the outer class has a ConditionalOnExpression which returns false. I guess as it is a different class found by spring on startup and it doesn't consider it related to the outer class. So i've simply duplicated the ConditionalOnExpression from the outer class to ExternalSslAwareEntryPoint.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the ExternalSslAwareEntryPoint component is being created even though the outer class has a ConditionalOnExpression which returns false. I guess as it is a different class found by spring on startup and it doesn't consider it related to the outer class.
So i've simply duplicated the ConditionalOnExpression from the outer class to ExternalSslAwareEntryPoint.
I'm not 100% convinced this is the correct fix - but i thought i'd take a shot at it :)