Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scripts): Adds initial sample script for non-X509 based script a… #416

Closed
wants to merge 1 commit into from
Closed

feat(scripts): Adds initial sample script for non-X509 based script a… #416

wants to merge 1 commit into from

Conversation

ttomsu
Copy link
Member

@ttomsu ttomsu commented Jun 27, 2017

…ccess.

@ttomsu ttomsu requested review from cfieber, ajordens and jtk54 June 27, 2017 17:28
jtk54
jtk54 reviewed Jun 27, 2017
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to spinnaker/spinnaker? Seems better organized that way since this is a standalone script.

@robzienert
Copy link
Member

What's the fate of this PR? Is it getting moved into spinnaker/spinnaker (I tend to agree with Jacob)?

@robzienert
Copy link
Member

Closing. Feel free to re-open if we're looking to actually merge this.

@robzienert robzienert closed this Nov 8, 2017
@spinnakerbot spinnakerbot mentioned this pull request May 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 left review comments

@cfieber cfieber Awaiting requested review from cfieber

@ajordens ajordens Awaiting requested review from ajordens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttomsu @robzienert @jtk54